Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Exec not working with reverse proxy X-Nomad-Token #12925

Merged
merged 3 commits into from
May 10, 2022
Merged

Fix Exec not working with reverse proxy X-Nomad-Token #12925

merged 3 commits into from
May 10, 2022

Conversation

legege
Copy link
Contributor

@legege legege commented May 9, 2022

This fixes an issue with Exec feature not working when a reverse proxy is used to automatically inject X-Nomad-Token.

@legege
Copy link
Contributor Author

legege commented May 9, 2022

More context can be found under MR #10563. Essentially, there was still a corner case that didn't work because Exec depends on a token being set in Local Storage. This is what is being fixed here. Thanks!

@philrenaud
Copy link
Contributor

Hi @legege ! Thanks for the contribution and for the supporting test.

There are a couple lint errors that should be fixed before merge; could you run cd ui && yarn run lint:js and push? If so, I'll get things merged asap.

@legege
Copy link
Contributor Author

legege commented May 10, 2022

@philrenaud Thanks for this quick review turnaround. Linting errors fixed.

@philrenaud philrenaud self-assigned this May 10, 2022
@philrenaud philrenaud merged commit 992c2f6 into hashicorp:main May 10, 2022
@lgfa29 lgfa29 added backport/1.1.x backport to 1.1.x release line backport/1.2.x backport to 1.1.x release line backport/1.3.x backport to 1.3.x release line labels Jun 6, 2022
lgfa29 added a commit that referenced this pull request Jun 6, 2022
@lgfa29
changelog: add entry for #12925
14d970c
This was referenced Jun 6, 2022
Merged
Merged
Merged
lgfa29 pushed a commit that referenced this pull request Jun 6, 2022
@legege @lgfa29
Fix Exec not working with reverse proxy X-Nomad-Token (#12925)
9db49c1 
* Capture token secret on fetch

* Fix tests

* Fix lint errors
lgfa29 pushed a commit that referenced this pull request Jun 6, 2022
@legege @lgfa29
Fix Exec not working with reverse proxy X-Nomad-Token (#12925)
873cf0c 
* Capture token secret on fetch

* Fix tests

* Fix lint errors
lgfa29 pushed a commit that referenced this pull request Jun 6, 2022
@hc-github-team-nomad-core @legege
Fix Exec not working with reverse proxy X-Nomad-Token (#12925) (#13251)
7e11112 
* Capture token secret on fetch

* Fix tests

* Fix lint errors

Co-authored-by: Georges-Etienne Legendre <georges-etienne.legendre@bell.ca>
lgfa29 pushed a commit that referenced this pull request Jun 6, 2022
@hc-github-team-nomad-core @legege
Fix Exec not working with reverse proxy X-Nomad-Token (#12925) (#13253)
57771fb 
* Capture token secret on fetch

* Fix tests

* Fix lint errors

Co-authored-by: Georges-Etienne Legendre <georges-etienne.legendre@bell.ca>
philrenaud pushed a commit that referenced this pull request Jun 8, 2022
@lgfa29
changelog: add entry for #12925 (#13250)
8071a64
@github-actions
Copy link

github-actions bot commented Oct 8, 2022

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@philrenaud philrenaud philrenaud approved these changes

@ChaiWithJai ChaiWithJai Awaiting requested review from ChaiWithJai

Assignees

@philrenaud philrenaud

Labels
backport/1.1.x backport to 1.1.x release line backport/1.2.x backport to 1.1.x release line backport/1.3.x backport to 1.3.x release line theme/ui
Projects
Nomad - Community Issues Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@legege @philrenaud @lgfa29 @DerekStrickland