Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nomad agent vault block config is not validated #13066

Open
shoenig opened this issue May 19, 2022 · 0 comments
Open

nomad agent vault block config is not validated #13066

shoenig opened this issue May 19, 2022 · 0 comments
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/vault type/bug

Comments

@shoenig
Copy link
Contributor

shoenig commented May 19, 2022

While trying to investigate #13062 I had this Nomad agent vault config:

vault {                                                                                                                                                                   
  enabled = true                                                                                                                                                          
  address = "http://127.0.0.1:8200"                                                                                                                                       
  token = "<token>"                                                                                                                                                                                                                                                               
  allows_unauthenticated = false                                                                                                                                          
} 

This is not valid as allows_unauthenticated should have been allow_unauthenticated, which is particularly bad since the config silently allows using vault unauthenticated.

@shoenig shoenig self-assigned this May 19, 2022
@shoenig shoenig added theme/vault stage/accepted Confirmed, and intend to work on. No timeline committment though. labels May 19, 2022
@shoenig shoenig modified the milestone: 1.3.x May 19, 2022
@shoenig shoenig removed their assignment May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stage/accepted Confirmed, and intend to work on. No timeline committment though. theme/vault type/bug
Projects
None yet
Development

No branches or pull requests

1 participant