Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "deps: update go-metrics to v0.5.3 in 1.6.x" #19375

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

lgfa29
Copy link
Contributor

@lgfa29 lgfa29 commented Dec 7, 2023

hashicorp/raft still uses armon/go-metrics which results in the incorrect global metric sink variable being used and metrics not being reported.

go-metrics can only be upgraded once all dependencies are also updated to use the new path.

Copy link
Member

@tgross tgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgross tgross merged commit de7110d into release/1.6.x Dec 8, 2023
@tgross tgross deleted the revert-19208-backport-19190-1-6-x branch December 8, 2023 13:47
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants