Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ui] Two small UI quality of life changes #19377

Merged
merged 3 commits into from
Dec 8, 2023
Merged

[ui] Two small UI quality of life changes #19377

merged 3 commits into from
Dec 8, 2023

Conversation

philrenaud
Copy link
Contributor

  • Disables the "Download as .nomad.hcl" button when running a job through the UI until the template has content (otherwise, you could download a blank file)
  • Removes the # of groups column from the jobs index page table

@philrenaud philrenaud self-assigned this Dec 8, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 8, 2023 •
edited
Loading

Ember Test Audit comparison

main 8b07999 change
passes 1540 1540 0
failures 0 0 0
flaky 0 0 0
duration 10m 58s 906ms 10m 54s 115ms -04s 791ms

juliezzhou
juliezzhou approved these changes Dec 8, 2023
View reviewed changes
Copy link

@juliezzhou juliezzhou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@philrenaud philrenaud added the backport/1.7.x backport to 1.7.x release line label Dec 8, 2023
@philrenaud philrenaud merged commit 5d2688a into main Dec 8, 2023
@philrenaud philrenaud deleted the ui-sync-fixes branch December 8, 2023 16:21
@hc-github-team-nomad-core hc-github-team-nomad-core mentioned this pull request Dec 8, 2023
Merged
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@juliezzhou juliezzhou juliezzhou approved these changes

@mikenomitch mikenomitch Awaiting requested review from mikenomitch

Assignees

@philrenaud philrenaud

Labels
backport/1.7.x backport to 1.7.x release line
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philrenaud @juliezzhou