Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] Random exec assignment chooses from only those with a matching taskGroup, if provided #19878

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

philrenaud
Copy link
Contributor

Resolves #10962

Previously, when selecting Exec from a group page in the UI (or selecting a task group/task from the exec window's left sidebar), we go over a given job's allocations until we find one that is active and whose name matches the selected one.

This becomes a problem in situations where a user has multiple (differently-named) groups, whose tasks share a name between them.

This PR filters down to the group name in question.

@philrenaud philrenaud requested a review from lgfa29 February 5, 2024 22:23
@philrenaud philrenaud self-assigned this Feb 5, 2024
@philrenaud philrenaud linked an issue Feb 5, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Feb 5, 2024

Ember Test Audit comparison

main a492da7 change
passes 1548 1548 0
failures 0 0 0
flaky 0 0 0
duration 11m 00s 454ms 10m 59s 858ms -596ms

Copy link
Contributor

@lgfa29 lgfa29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Probably worth backporting how far as possible.

@philrenaud philrenaud added backport/1.4.x backport to 1.4.x release line backport/1.5.x backport to 1.5.x release line backport/1.6.x backport to 1.6.x release line backport/1.7.x backport to 1.7.x release line labels Feb 6, 2024
@philrenaud philrenaud merged commit c927377 into main Feb 6, 2024
23 checks passed
@philrenaud philrenaud deleted the 10962-ui-exec-ui-selects-wrong-allocation branch February 6, 2024 04:23
@philrenaud philrenaud added backport/1.6.x backport to 1.6.x release line backport/1.7.x backport to 1.7.x release line and removed backport/1.6.x backport to 1.6.x release line backport/1.7.x backport to 1.7.x release line labels Feb 7, 2024
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport/1.4.x backport to 1.4.x release line backport/1.5.x backport to 1.5.x release line backport/1.6.x backport to 1.6.x release line backport/1.7.x backport to 1.7.x release line theme/ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ui] Exec UI selects wrong allocation
2 participants