-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: update consul-template to 0.37.4 to fix resource leak #20234
Conversation
aa774dd
to
45aa1a3
Compare
A Nomad user reported an issue where template runner `View.poll` goroutines were being leaked when using templates with many dependencies. This resource leak was fixed in consul-template 0.37.4. Fixes: #20163
45aa1a3
to
98fa14f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🕷️
A Nomad user reported an issue where template runner `View.poll` goroutines were being leaked when using templates with many dependencies. This resource leak was fixed in consul-template 0.37.4. Fixes: #20163
A Nomad user reported an issue where template runner `View.poll` goroutines were being leaked when using templates with many dependencies. This resource leak was fixed in consul-template 0.37.4. Fixes: #20163
A Nomad user reported an issue where template runner `View.poll` goroutines were being leaked when using templates with many dependencies. This resource leak was fixed in consul-template 0.37.4. Fixes: #20163
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
A Nomad user reported an issue where template runner
View.poll
goroutines were being leaked when using templates with many dependencies. This resource leak was fixed in consul-template 0.37.4.Fixes: #20163