Fixed permissions of migrated allocation directories #2061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diptanu
force-pushed
the
b-alloc-dir-perms
branch
from
6164ccd
to
2c8e85a
Compare
diptanu
changed the title
dadgar
approved these changes
Dec 6, 2016
| return nil, err | ||
| } | ||
|
|
||
| // If there were no erorrs then we create the allocdir |
| return prevAllocDir, nil | ||
| } | ||
|
|
||
| // unarchiveAllocDir reads the stream of compressed allocation directory and |
| @@ -1586,40 +1598,38 @@ func (c *Client) migrateRemoteAllocDir(alloc *structs.Allocation, allocID string | |||
| stopMigrating, ok := c.migratingAllocs[allocID] | |||
| if !ok { | |||
| os.RemoveAll(pathToAllocDir) | |||
| return nil, fmt.Errorf("couldn't find a migration validity notifier for alloc: %v", alloc.ID) | |||
| return fmt.Errorf("couldn't find a migration validity notifier for alloc: %v", allocID) | |||
There was a problem hiding this comment.
Very odd message. "Allocation %q is not marked for remote migration"
diptanu
force-pushed
the
b-alloc-dir-perms
branch
from
2c8e85a
to
33e7d12
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2053