Consul Connect: Fix validation with multiple local_bind_socket_paths

[sundbry]

When a consul connect sidecar service is defined with multiple local_bind_socket_path upstreams, validation fails due to duplicate socket address bindings on :0 being detected:

Error submitting job: Unexpected response code: 500 (1 error occurred:
        * Consul Connect services "caddy-https" and "caddy-https" in group "caddy" using same address for upstreams (:0))

This patch validates local_bind_socket_path upstreams separately from local_bind_address sockets.

[tgross]

Hi @sundbry! Thanks for this fix. I've left a comment about reusing the map. Also:

• You'll want to gofmt -s the file when you're done to make the lint check happy
• Can you run make cl to create a changelog entry?

[sundbry]

Hi @tgross, thanks for the review - I have resubmitted it after changes + added a changelog entry.

[tgross]

LGTM! Thanks @sundbry!

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.