-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix CSITopology matching logic for csi storage driver #24522
Conversation
…ully equal to the other topology's segements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @thefallentree! Thanks for this PR. In addition to resolving the compilation errors and the items I noted in the comments, please run make cl
to add a changelog entry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @thefallentree!
I've push a small commit to make the changelog message applicable to more users, and tidied up some style items in the unit test (we're trying to get rid of testify
on Nomad). Once CI is green, I'll merge this and get it backported.
Description
CSI volume is created with following topology
and Node Accessible Topology is reported as
The current logic assume they completely match, where the accessible topology's Segements just need to be a superset of the volume topology's Segements
Up until EBS CSI driver version < 1.26.1 , the reported value matches exactly, and after v1.27.0 it has been broken since.
Testing & Reproduction steps
without this patch , the e2e test for csi driver with a ebs-csi driver > 1.26.1 will fail.
Links
fix #20094
Contributor Checklist
changelog entry using the
make cl
command.ensure regressions will be caught.
and job configuration, please update the Nomad website documentation to reflect this. Refer to
the website README for docs guidelines. Please also consider whether the
change requires notes within the upgrade guide.
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.