Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Character restrictions in action names were unduly oppressive #24642

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

philrenaud
Copy link
Contributor

Description

Lifts the naming restriction on task actions so that you can put user-friendly emoji in there if you were so inclined.

image

@philrenaud philrenaud self-assigned this Dec 10, 2024
@philrenaud philrenaud requested review from a team as code owners December 10, 2024 18:57
ksatirli
ksatirli previously approved these changes Dec 10, 2024
Copy link
Member

@ksatirli ksatirli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love it!

This is a solid improvement for making Action names visually distinct.

schmichael
schmichael previously approved these changes Dec 12, 2024
Copy link
Member

@schmichael schmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🎉 :shipit:

@philrenaud philrenaud added the backport/1.9.x backport to 1.9.x release line label Dec 12, 2024
@philrenaud philrenaud merged commit f452948 into main Dec 12, 2024
29 checks passed
@philrenaud philrenaud deleted the f-ui/action-names-deserve-a-little-treat branch December 12, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/1.9.x backport to 1.9.x release line
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants