reporting: Update server to accommodate new enterprise reporting. #24919
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nomad Enterprise will utilise new reporting metrics and the changes here allow this work to be conducted.
The server specific GetClientNodesCount function has been removed from CE as this is only called within enterprise code. A new heartbeater function allows us to get the number of active timers, which can be used by the heartbeater metrics and any other callers that want this data.
PR Process Notes
This has been originally reviewed within the enterprise codebase.
In order to juggle the CE and Enterprise specific code portions, I plan on backporting this change to CE only and then performing manual merging into Enterprise along with the specific changes needed there.
Once the merging juggling has been complete, I will raise a followup documentation and changelog PR.
Links
Jira: https://hashicorp.atlassian.net/browse/NET-9340
Contributor Checklist
changelog entry using the
make cl
command.ensure regressions will be caught.
and job configuration, please update the Nomad website documentation to reflect this. Refer to
the website README for docs guidelines. Please also consider whether the
change requires notes within the upgrade guide.
Reviewer Checklist
backporting document.
in the majority of situations. The main exceptions are long-lived feature branches or merges where
history should be preserved.
within the public repository.