[ui] Multi-condition start/revert/edit buttons when a job isn't running #24985
Conversation
philrenaud
force-pushed
the
f-ui/24980-better-job-start-button
branch
from
e812503 to
d1fb845
Compare
| @@ -1215,3 +1217,117 @@ function getScenarioQueryParameter() { | |||
| return mirageScenario; | |||
| } | |||
| /* eslint-enable */ | |||
|
|
|||
| export function createRestartableJobs(server) { | |||
There was a problem hiding this comment.
Sets jobs/versions up both in our mocked mirage smallCluster (where we can preview this), but also in a way that our tests can leverage it easily via import.
philrenaud
force-pushed
the
f-ui/24980-better-job-start-button
branch
from
5a927eb to
02e2161
Compare
philrenaud
force-pushed
the
f-ui/24980-better-job-start-button
branch
from
02e2161 to
cad7a7a
Compare
ui/app/routes/jobs/job/index.js
Outdated
| // TODO: looks like this watcher is pushing me over the "Browser is freaking out" max connections limit | ||
| // versions: this.watchVersions.perform(model), |
There was a problem hiding this comment.
Does commenting this out leave the watchRelationship defined below orphaned? Any consequence to that? Missing this doesn't seem to generate any extra HTTP requests from what I can see in the devtools.
There was a problem hiding this comment.
yeah it's only this line in the controller.set('watchers' bit that causes the extra blocking-query stuff.
I left this commented out because I wanted to be consistent on this page about how we watch for resource updates, but I think I've just made peace with loading it on-demand via the component. Going to remove the versions-loading stuff from the route file.
philrenaud
force-pushed
the
f-ui/24980-better-job-start-button
branch
from
b146684 to
aa3eba3
Compare
Stopped:
Failed, but once upon a time it was running:
Failed, has always been a failure:
Resolves #24980