Task route hierarchy in the UI #3472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thrashr888
reviewed
Nov 3, 2017
|
|
||
| model({ name }) { | ||
| const allocation = this.modelFor('allocations.allocation'); | ||
| if (allocation) { |
There was a problem hiding this comment.
If allocation is falsey, the allocation route model hook will set the application error state.
thrashr888
reviewed
Nov 3, 2017
| export default Controller.extend({ | ||
| network: computed.alias('model.resources.networks.firstObject'), | ||
| ports: computed('network.reservedPorts.[]', 'network.dynamicPorts.[]', function() { | ||
| const ports = this.get('network.reservedPorts') |
There was a problem hiding this comment.
can probably just return here
thrashr888
reviewed
Nov 3, 2017
| <div class="boxed-section is-small"> | ||
| <div class="boxed-section-body inline-definitions"> | ||
| <span class="label">Task Details</span> | ||
| <span class="pair"> |
There was a problem hiding this comment.
can try dl/dd here instead of .pair, if that makes the css any easier.
There was a problem hiding this comment.
Maybe. It would certainly be semantically better.
thrashr888
reviewed
Nov 3, 2017
| @@ -105,83 +111,17 @@ test('each task row should list high-level information for the task', function(a | |||
| ); | |||
|
|
|||
| assert.ok(reservedPorts.length, 'The task has reserved ports'); | |||
| assert.ok(dynamicPorts.length, 'The task has reserved ports'); | |||
thrashr888
approved these changes
Nov 3, 2017
Drilling into a task from an allocation transitions to the task heirarchy.
Now that there is a task detail page, some of the content from the allocation detail page is better suited there.
DingoEatingFuzz
force-pushed
the
f-ui-task-hierarchy
branch
from
6aa93c8 to
b3dc736
Compare
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making room for logs and file browsing.
Updated allocation detail page:
New task overview page:
