Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric prefix filtering #4878

Merged
merged 5 commits into from
Nov 15, 2018
Merged

Metric prefix filtering #4878

merged 5 commits into from
Nov 15, 2018

Conversation

nickethier
Copy link
Member

@nickethier nickethier commented Nov 14, 2018

This PR introduces three new options to the telemetry config block:

  • filter_default - This controls whether to allow metrics that have not been specified by the filter. Modeled after the option in Consul
  • prefix_filter - This is modeled after the option in Consul for defining prefixes to include and exclude from metrics
  • disable_dispatched_job_summary_metrics - This long winded option disables registration of job_summary metrics entirely if the job has been dispatched from a parameterized job. Improve Telemetry for Dispatch Jobs #4422 Explains why you might want this. Additionally if you are dispatching a high volume of jobs you can reclaim the memory overhead used by summary stats tracking of each job for scheduling. This can be significant in large deployments.

fixes #4864

command/agent/config.go Show resolved Hide resolved
command/agent/config.go Show resolved Hide resolved
nomad/leader.go Outdated Show resolved Hide resolved
Copy link
Contributor

@dadgar dadgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after small changes

command/agent/config_test.go Show resolved Hide resolved
nomad/leader.go Outdated Show resolved Hide resolved
@nickethier nickethier merged commit 3a826a0 into release-087 Nov 15, 2018
nickethier added a commit that referenced this pull request Nov 20, 2018
@nickethier nickethier deleted the f-metric-prefix branch November 30, 2018 03:27
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants