-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metric prefix filtering #4878
Metric prefix filtering #4878
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM after small changes
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
This PR introduces three new options to the
telemetry
config block:filter_default
- This controls whether to allow metrics that have not been specified by the filter. Modeled after the option in Consulprefix_filter
- This is modeled after the option in Consul for defining prefixes to include and exclude from metricsdisable_dispatched_job_summary_metrics
- This long winded option disables registration of job_summary metrics entirely if the job has been dispatched from a parameterized job. Improve Telemetry for Dispatch Jobs #4422 Explains why you might want this. Additionally if you are dispatching a high volume of jobs you can reclaim the memory overhead used by summary stats tracking of each job for scheduling. This can be significant in large deployments.fixes #4864