Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Go11Modules go.mod? #5444

Closed
prologic opened this issue Mar 20, 2019 · 7 comments
Closed

Go11Modules go.mod? #5444

prologic opened this issue Mar 20, 2019 · 7 comments
Assignees
Labels
theme/dependencies Pull requests that update a dependency file type/enhancement

Comments

@prologic
Copy link

How are you guys managing dependencies? I see a vendor/ directory but nothing managing it? Would you accept a PR that adds a go.mod and go.sum based off of what's currently in vendor/?

@notnoop
Copy link
Contributor

notnoop commented Mar 20, 2019

Thanks @prologic for the offer. As you have figured out already, we are currently using govendor.

We intend to switch to using go mod after releasing 0.9, and there is an ongoing effort to adopt go modules across the HashiCorp organization. Our initial research pointed to few trade-offs in setting nomad repo as a single module; e.g. needing to have /api package as a separate module, and potentially extracting plugins/drivers potentially from repo. Simple conversion of vendor/ into go mod wouldn't be an acceptable solution at this time.

Keep an eye for adoption of go mod after 0.9.0 ships.

@notnoop notnoop closed this as completed Mar 20, 2019
@Xuanwo
Copy link

Xuanwo commented Sep 4, 2019

@notnoop It's going to release 0.10 for now, and go 1.13 with modules enabled by default released. Is there any roadmap for nomad to migrate to go mod? I'm developing a nomad plugin and vendor troubled me a lot.

@notnoop
Copy link
Contributor

notnoop commented Sep 6, 2019

@Xuanwo Thanks for reaching out. We do plan to ease developing plugins with go mod against nomad as it's go mod is the way to go now. We are researching what's involved and will figure out what to do.

@ThomasObenaus
Copy link

Hi @notnoop,
I'd like to move to go mod with my project, but at the moment I'm kind of blocked since nomad does not support go mod currently.
Do you have an update about the progress for the migration of nomad to go modules?

@schmichael schmichael reopened this Jun 2, 2020
@schmichael
Copy link
Member

Reopening as we're actively working on switching to Go modules.

@schmichael schmichael added theme/dependencies Pull requests that update a dependency file type/enhancement labels Jun 2, 2020
@notnoop
Copy link
Contributor

notnoop commented Jun 22, 2020

Closing this issue now as we are using go mod for Nomad 0.12.

@notnoop notnoop closed this as completed Jun 22, 2020
@github-actions
Copy link

github-actions bot commented Nov 6, 2022

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
theme/dependencies Pull requests that update a dependency file type/enhancement
Projects
None yet
Development

No branches or pull requests

6 participants