Filter deployments by create index #5702
Merged
+109
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 14, 2019 16:13
preetapan
force-pushed
the
f-filter-by-create-index
branch
from
71a1c70
to
fa79336
Compare
endocrimes
approved these changes
May 15, 2019
schmichael
reviewed
May 15, 2019
langmartin
approved these changes
May 15, 2019
| @@ -270,8 +270,10 @@ func (s *HTTPServer) jobDeployments(resp http.ResponseWriter, req *http.Request, | |||
| if req.Method != "GET" { | |||
| return nil, CodedError(405, ErrInvalidMethod) | |||
| } | |||
| all, _ := strconv.ParseBool(req.URL.Query().Get("all")) | |||
There was a problem hiding this comment.
is the behavior of ParseBool for an empty string the only thing that makes all default to false? If so, maybe that needs a comment? It's builtin to go, maybe it doesn't
Co-Authored-By: Danielle <dani@builds.terrible.systems>
… into f-filter-by-create-index
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to only view deployments for the most recent version of the job, similar to how job status --all-allocs work. By default, only deployments associated with the most recently created version of the job are returned.
Prior to this change, if a job was purged and recreated with the same id,
nomad job deployments <jobid>would show all deployments. With this PR, adding--allwill show all deployments, otherwise only deployments associated with the recreated job are shown.TODO