-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Allocation lifecycle #5734
UI: Allocation lifecycle #5734
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Michael!
Just spotted a little typo for now, will try come back here later for a better look unless someone beats me to it!
Thanks,
John
ui/app/components/two-step-button.js
Outdated
onConfirm() {}, | ||
onCancel() {}, | ||
|
||
state: 'idle', | ||
isIdle: equal('state', 'idle'), | ||
isPendingConfirmation: equal('state', 'prompt'), | ||
|
||
cancelOnClickOutisde: task(function*() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo 👮 ! Outisde
> Outside
and obvs below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a clear and clean addition to me, nice! I made one small comment about the use of page objects in an integration test but it’s not a blocking thing, more an inquiry.
this.setProperties(props); | ||
await render(commonTemplate); | ||
|
||
click('[data-test-idle-button]'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an existing test so maybe it’s just about following what’s already here, but I was wondering if it wouldn’t make sense to use the page object component here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah I think this makes sense! I wrote this test before I made the TwoStepButton page object. I'll go back and update it.
9714d7a
to
2002836
Compare
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
UI support for allocation stop and restart and task restart.
Integrates with blocking queries to give live-updating of task restarts, including task events, as well as allocation stop, including rescheduled allocation client status.
Stop and restart buttons on the allocation detail page
Confirmation text for stopping
After stopping an allocation, the reschedule events lead to the new allocation.
Confirmation text for restarting
Restart button and task events on the task detail page