Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Allocation lifecycle #5734

Merged
merged 11 commits into from
May 21, 2019
Merged

UI: Allocation lifecycle #5734

merged 11 commits into from
May 21, 2019

Conversation

DingoEatingFuzz
Copy link
Contributor

UI support for allocation stop and restart and task restart.

Integrates with blocking queries to give live-updating of task restarts, including task events, as well as allocation stop, including rescheduled allocation client status.

image
Stop and restart buttons on the allocation detail page

image
Confirmation text for stopping

image
After stopping an allocation, the reschedule events lead to the new allocation.

image
Confirmation text for restarting

image
Restart button and task events on the task detail page

@DingoEatingFuzz DingoEatingFuzz requested a review from a team May 21, 2019 00:30
Copy link
Contributor

@johncowen johncowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Michael!

Just spotted a little typo for now, will try come back here later for a better look unless someone beats me to it!

Thanks,

John

onConfirm() {},
onCancel() {},

state: 'idle',
isIdle: equal('state', 'idle'),
isPendingConfirmation: equal('state', 'prompt'),

cancelOnClickOutisde: task(function*() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo 👮 ! Outisde > Outside and obvs below.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed!

Copy link
Contributor

@backspace backspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a clear and clean addition to me, nice! I made one small comment about the use of page objects in an integration test but it’s not a blocking thing, more an inquiry.

this.setProperties(props);
await render(commonTemplate);

click('[data-test-idle-button]');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an existing test so maybe it’s just about following what’s already here, but I was wondering if it wouldn’t make sense to use the page object component here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah I think this makes sense! I wrote this test before I made the TwoStepButton page object. I'll go back and update it.

@github-actions
Copy link

github-actions bot commented Feb 9, 2023

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants