Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] consul & vault hyperlinks #5860

Closed
SudoerWithAnOpinion opened this issue Jun 19, 2019 · 9 comments · Fixed by #11557
Closed

[feature] consul & vault hyperlinks #5860

SudoerWithAnOpinion opened this issue Jun 19, 2019 · 9 comments · Fixed by #11557

Comments

@SudoerWithAnOpinion
Copy link

Since the "HashiStack" is designed to be used all together, can a link be added (via config or consul auto-discover) to the other component of the stack?

I'd like to be able to click on the nomad logo and be presented a simple menu to jump to consul & vault (and maybe other services by config file)

@preetapan
Copy link
Contributor

@TheRevenantStar Can you clarify if you mean in our UI or in the project website?

@SudoerWithAnOpinion
Copy link
Author

SudoerWithAnOpinion commented Jun 20, 2019 via email

@DingoEatingFuzz
Copy link
Contributor

This has been in the back of my mind for awhile now, so I'm glad others are thinking similarly :)

Doing this properly will require coordinating with other products and (ideally) deep-linking to things like services, intentions, and secrets.

There's chatter about all this internally, but the best I can say now is stay tuned, and I hope browser bookmarks aren't too troublesome in the meantime.

@OneCricketeer
Copy link

Related to #6410 & #7056

@ChaiWithJai
Copy link
Contributor

@mikenomitch I think this ticket needs to be broken up into 2 separate issues. One re: changing the ui config block and then implementing the changes in the ui because right now we don't have access to the information we need.

cc: @lgfa29 @tgross unsure who on the backend has bandwidth for this and when they'll have bandwidth.

@mikenomitch
Copy link
Contributor

@ChaiWithJai If you don't mind, let's keep this as a single issue since I think just having the UI block without the UI isn't really delivering value.

That said, we'll need to figure out how to coordinate on our side, but hopefully shouldn't be too bad passing this off from backend to frontend.

@mikenomitch mikenomitch assigned tgross and unassigned juliezzhou and tgross Nov 18, 2021
@tgross tgross self-assigned this Nov 19, 2021
@tgross
Copy link
Member

tgross commented Nov 19, 2021

@mikenomitch @ChaiWithJai I'm looking at this and I'm a little unclear as to what we're looking to implement. I'd scoped out deep links for services in #10583 (much of which came from (internal ref)), but this issue looks like it's just about having the Nomad menu include a link out to a Consul and/or Vault server?

If so, that would make the server-side requirements of this issue:

  • A ui config block on the server (does nothing within the next bit)
  • A ui.consul (or ui.consul_url or maybe ui.consul.url?) and ui.vault config within that block, that gets exposed to the web UI via the API somehow...

As for that "somehow...", our ui route is a "file" server over the embedded static assets. We have a way to add headers in handleUI but the content isn't otherwise dynamic outside of the API. But we already expose a /agent/self API that includes certain bits of the server's configuration. So I'll look at adding the fields there if there aren't any objections.

@juliezzhou
Copy link

FYI, this is the screenshot of what the UI should look like.
hyperlink

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants