Update go-getter@1.1.0 to fix #3491

[hmalphettes]

As reported in #3491, nomad run example.nomad on windows without the symbolic link creation privileges fails.

As suggested in hashicorp/go-getter#159, a workaround was added to the go-getter source.
However go-getter in nomad has not been updated to benefit from this fix.

This pull request is an update to go-getter.

I have tested that it does fix #3491
Thanks @azr for the actual fix in go-getter!

[hmalphettes]

For now staying at v1.1.0 of go-getter to keep the actual change limited to changes in the vendor/github.com/hashicorp/go-getter/ folder.

Later versions of go-getter require to add to the vendor folder cloud.google.com/api and cloud.google.com/go and are not required to fix the Windows issue.

[greut]

iirc make dev (or make vendorfmt) should reformat the vendor.json file to keep the diff easy on the eye.

[hmalphettes]

Thanks @greut ! Fixed that.

I triggered 3 travis builds with the same changes and got 3 different failures:

• a timeout - cleaned up since yesterday
• a failure on the client package test suite: https://travis-ci.org/hashicorp/nomad/builds/563781894
• a failure on the nomad package test suite: https://travis-ci.org/hashicorp/nomad/builds/563639318

If I am missing something please let me know

[schmichael]

Thanks @hmalphettes ! I think you just got unlucky on some flaky tests. Sorry. Trying again.

I think we want to wait to merge this into 0.10.0 (which will become master once 0.9.4-final is released) at which point let's pull in the latest release (looks like v1.3.0 instead of v1.1.0).

[hmalphettes]

Thanks @schmichael!

In the mean time, if it is useful for someone - and you happen to trust my own build of nomad - I uploaded a windows build with this patch: https://github.com/hmalphettes/nomad/releases/tag/v0.9.4-rc1h
My colleagues and I are happily using it from our locked-down windows machines to prototype the jobs.
I'll update it when 0.9.4 is released.

If this is not good community etiquette to point at my build, please do delete this comment or let me know.

[schmichael]

Thanks @hmalphettes ! Merged. Linking to forks and prebuilt binaries is great as long as you make it clear it's a fork (which you did).

[github-actions]

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.