Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: fix panic when AllocatedResources is nil #6541

Merged
merged 1 commit into from
Oct 31, 2019
Merged

core: fix panic when AllocatedResources is nil #6541

merged 1 commit into from
Oct 31, 2019

Conversation

schmichael
Copy link
Member

Potential fix for #6540

@dekimsey
Copy link
Collaborator

I thought circleci had a way to grab the artifact, but I'm not seeing it anywhere obvious. Let me know where to grab it and I'll be happy to go test it.

@schmichael
Copy link
Member Author

@dekimsey I feel like I used to be able to add binaries to GH issues/PRs, but now it's telling me the size limit is 10mb. Here's a Google Drive link that should work: https://drive.google.com/open?id=1tsZecFdcip3Glz4LC00DkyfHUT6RBuc1

@dekimsey
Copy link
Collaborator

Thanks @schmichael, lgfa29 gave me a link late yesterday. I tested it this morning and confirmed it addressed the crash. I reported this in the ticket earlier today. I'm sorry I didn't ping you!

@schmichael schmichael added this to the 0.10.1 milestone Oct 25, 2019
@schmichael schmichael marked this pull request as ready for review October 25, 2019 22:23
endocrimes
endocrimes approved these changes Oct 28, 2019
View reviewed changes
Copy link
Contributor

@endocrimes endocrimes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one comment about a comment.

A test would be nice for this, but it'd be fairly tricky to force I think so I won't block on it.

scheduler/util.go Show resolved Hide resolved
@schmichael schmichael merged commit 20bb9f0 into master Oct 31, 2019
@schmichael schmichael deleted the release-0100-net-panic branch October 31, 2019 15:46
schmichael added a commit that referenced this pull request Oct 31, 2019
@schmichael
Merge pull request #6541 from hashicorp/release-0100-net-panic
7a56408 
core: fix panic when AllocatedResources is nil
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@endocrimes endocrimes endocrimes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.1
Development

Successfully merging this pull request may close these issues.
4 participants
@schmichael @dekimsey @endocrimes @samm-git