Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update consul vendor and add MinQuorum flag #7171

Merged
merged 3 commits into from
Feb 19, 2020
Merged

Conversation

notnoop
Copy link
Contributor

@notnoop notnoop commented Feb 17, 2020

Update consul's autopilot to pick up dead server cleanup fix hashicorp/consul#4017; also ports MinQuorum autopilot flag features hashicorp/consul#6654 from Consul to nomad

Also, updated rest of consul testutil for general hygiene purposes.

Closes #7021
Closes #6785

@notnoop notnoop added this to the 0.11.0 milestone Feb 17, 2020
@notnoop notnoop requested a review from shoenig February 17, 2020 23:39
@notnoop notnoop self-assigned this Feb 17, 2020
@shoenig
Copy link
Member

shoenig commented Feb 19, 2020

LGTM

@notnoop notnoop merged commit 90381d8 into master Feb 19, 2020
@notnoop notnoop deleted the update-autopilot-20200214 branch February 19, 2020 16:45
@onlyjob
Copy link
Contributor

onlyjob commented Feb 19, 2020

Why Consul is vendored by commit b137060630b463d7ad5360f0d8f32f9347ae3b7d which do not match any of Consul releases??

Please only ever vendor formal releases for best practice.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Consul's Autopilot dependency please upgrade vendored consul
3 participants