resolve prefix bugs around job scaling policies #8753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cgbaker
force-pushed
the
b-scaling-policy-delete-job-prefix
branch
from
78e1add
to
1ea550d
Compare
jrasell
approved these changes
Aug 27, 2020
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are numerous places where scaling policies had incorrect prefix searches:
This PR addresses these. The first commit (1a9318a) shows the failures of the new documenting tests: https://app.circleci.com/pipelines/github/hashicorp/nomad/11402/workflows/0ff139bb-1268-4ae8-abae-ff5f77082459/jobs/95138
The second commit (1ea550d) fixes the issues and tests clean:
https://app.circleci.com/pipelines/github/hashicorp/nomad/11404/workflows/4a1e0402-8b00-4423-8089-2f1ca3cbb0b5