Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document detailed logs and upgrade image to Packer v1.7.0 #17

Merged
merged 10 commits into from
Feb 27, 2021

Conversation

sylviamoss
Copy link
Contributor

@sylviamoss sylviamoss commented Feb 26, 2021

@sylviamoss
Copy link
Contributor Author

@ksatirli I tried fixing the readme with markdownlint -f README.md but apparently wasn't enough. Could you help to fix it?

- [command](#command)
- [arguments](#arguments)
- [target](#target)
- [`command`](#command)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice - reads better!

sylviamoss and others added 3 commits February 26, 2021 12:28
…ions into document_logs

* 'document_logs' of github.com:ksatirli/packer-github-actions:
  add init command to the list
Copy link
Member

@ksatirli ksatirli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

Copy link

@nywilken nywilken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. Nicely done.

@nywilken nywilken merged commit f3ef35b into master Feb 27, 2021
@nywilken nywilken deleted the document_logs branch February 27, 2021 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default target is not useful Target marked both "default" and "required"
3 participants