boolean to make run_tags the same as tags

[nitrocode]

Please search the existing issues for relevant feature requests, and use the
reaction feature
(https://blog.github.com/2016-03-10-add-reactions-to-pull-requests-issues-and-comments/)
to add upvotes to pre-existing requests.

Feature Description

I'd like to make run_tags the same as tags using a boolean like "tags_same" = true, or similar which can make all tagging the same as what is defined in tags.

Use Case(s)

Tired of adding new tags to one but not the other. I'd like to keep things DRY as much as possible.

[azr]

Hello @nitrocode, thanks for opening. We recently merged #8588 that allows to use variables in HCL2. I would like to talk about the feasibility of this in Packer HCL2 and how I think it should/will proably work ( we are not quite there yet ):

1/ I think we should add the possibility to define the tag field instead of tags, to be defined like this:

source "amazon-ebs" "example-source" {
  tag {
    key                 = "Name"
    value               = "example-asg-name"
    propagate_at_launch = false
  }
  //...

I think this would solve one issue here.

2/ from there we will need to introduce the dynamic block from Terraform

locals {
  standard_tags = {
    Component   = "user-service"
    Environment = "production"
  }
}

source "amazon-ebs" "example-source" {
  // same as before
  dynamic "tag" {
    for_each = local.standard_tags

    content {
      key                 = tag.key
      value               = tag.value
      propagate_at_launch = true
    }
}

[azr]

Here are the places where that could be handy:

Builders:

https://github.com/hashicorp/packer/blob/ecaec1ac584895dd8588ba3ffa4e74afad2be20b/builder/alicloud/ecs/image_config.go#L194

packer/builder/amazon/common/ami_config.go

Line 107 in d084cd1

AMIRegionKMSKeyIDs map[string]string `mapstructure:"region_kms_key_ids" required:"false"`

packer/builder/amazon/common/run_config.go

Line 200 in 6655f93

RunTags map[string]string `mapstructure:"run_tags" required:"false"`

packer/builder/amazon/common/run_config.go

Line 284 in 6655f93

SpotTags map[string]string `mapstructure:"spot_tags" required:"false"`

packer/builder/amazon/common/ami_config.go

Line 52 in d084cd1

AMITags TagMap `mapstructure:"tags" required:"false"`

packer/builder/amazon/ebsvolume/block_device.go

Line 16 in 239f974

Tags awscommon.TagMap `mapstructure:"tags" required:"false"`

packer/builder/cloudstack/config.go

Line 164 in 0785c2f

Tags map[string]string `mapstructure:"tags"`

packer/builder/docker/config.go

Line 80 in 0785c2f

Volumes map[string]string `mapstructure:"volumes" required:"false"`

packer/builder/googlecompute/config.go

Line 83 in 0785c2f

ImageLabels map[string]string `mapstructure:"image_labels" required:"false"`

packer/builder/googlecompute/config.go

Line 83 in 0785c2f

ImageLabels map[string]string `mapstructure:"image_labels" required:"false"`

packer/builder/googlecompute/config.go

Line 94 in 0785c2f

Metadata map[string]string `mapstructure:"metadata" required:"false"`

packer/builder/googlecompute/config.go

Line 96 in 0785c2f

MetadataFiles map[string]string `mapstructure:"metadata_files"`

packer/builder/hcloud/config.go

Line 38 in 0785c2f

SnapshotLabels map[string]string `mapstructure:"snapshot_labels"`

packer/builder/hyperone/config.go

Line 65 in 0785c2f

ImageTags map[string]string `mapstructure:"image_tags" required:"false"`

packer/builder/hyperone/config.go

Line 74 in 0785c2f

VmTags map[string]string `mapstructure:"vm_tags" required:"false"`

packer/builder/lxd/config.go

Line 38 in 0785c2f

PublishProperties map[string]string `mapstructure:"publish_properties" required:"false"`

packer/builder/lxd/config.go

Line 41 in 0785c2f

LaunchConfig map[string]string `mapstructure:"launch_config" required:"false"`

packer/builder/openstack/image_config.go

Line 18 in 6305c55

ImageTags []string `mapstructure:"image_tags"`

packer/builder/openstack/run_config.go

Line 140 in 5da5b00

InstanceMetadata map[string]string `mapstructure:"instance_metadata" required:"false"`

packer/builder/openstack/run_config.go

Line 192 in 5da5b00

Properties map[string]string `mapstructure:"properties"`

packer/builder/oracle/oci/config.go

Line 68 in 0785c2f

Tags map[string]string `mapstructure:"tags"`

packer/builder/osc/bsuvolume/block_device.go

Line 10 in 80dadaf

Tags osccommon.TagMap `mapstructure:"tags"`

packer/builder/osc/common/omi_config.go

Line 20 in 793b3f1

OMITags TagMap `mapstructure:"tags"`

packer/builder/tencentcloud/cvm/run_config.go

Line 85 in 6fb8988

packer/builder/triton/source_machine_config.go

Lines 54 to 57 in 078ba7c

	MachineMetadata map[string]string `mapstructure:"source_machine_metadata" required:"false"`
	// Tags applied to the
	// VM used to create the image.
	MachineTags map[string]string `mapstructure:"source_machine_tags" required:"false"`

packer/builder/triton/target_image_config.go

Line 38 in 4399684

ImageTags map[string]string `mapstructure:"image_tags" required:"false"`

packer/builder/vmware/common/vmx_config.go

Lines 13 to 17 in 4399684

	VMXData map[string]string `mapstructure:"vmx_data" required:"false"`
	// Identical to vmx_data,
	// except that it is run after the virtual machine is shutdown, and before the
	// virtual machine is exported.
	VMXDataPost map[string]string `mapstructure:"vmx_data_post" required:"false"`

packer/builder/vsphere/common/step_config_params.go

Line 16 in 073eda7

ConfigParams map[string]string `mapstructure:"configuration_parameters"`

packer/builder/yandex/config.go

Line 60 in 0785c2f

ImageLabels map[string]string `mapstructure:"image_labels" required:"false"`

packer/builder/yandex/config.go

Line 76 in 0785c2f

Labels map[string]string `mapstructure:"labels" required:"false"`

packer/builder/yandex/config.go

Lines 82 to 84 in 0785c2f

	Metadata map[string]string `mapstructure:"metadata" required:"false"`
	// Metadata applied to the launched instance. Value are file paths.
	MetadataFromFile map[string]string `mapstructure:"metadata_from_file"`

There are also post-processors where that could be used.

Note that this wouldn't necessarily be a breaking change as a new tag/property field would be introduced. We would have to sort of deprecate tags/properties fields and may be come up with a way to help users fix their templates, ( or don't, and not deprecate anything ).

[azr]

Hey there, yesterday I opened #8720 that adds support for dynamic blocks. Up next we will need to add that new tag specific type.

[ghost]

This issue has been automatically migrated to hashicorp/packer-plugin-amazon#10 because it looks like an issue with that plugin. If you believe this is not an issue with the plugin, please reply to hashicorp/packer-plugin-amazon#10.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.