Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to fsync properly when saving snapshot files #229

Closed
preetapan opened this issue Aug 3, 2017 · 2 comments
Closed

Make sure to fsync properly when saving snapshot files #229

preetapan opened this issue Aug 3, 2017 · 2 comments
Assignees
@preetapan

Comments

@preetapan
Copy link

file_snapshot.go doesn't explicitly call fsync before close(). This leads to an edge case during machine crashes where the file we renamed doesn't exist on disk.
@preetapan preetapan self-assigned this Aug 3, 2017
@romfreiman
Copy link

For more info: https://groups.google.com/forum/#!msg/consul-tool/8l0WNatZ8N8/Ygjja_DuFwAJ

@preetapan
Copy link
Author

@slackpad merged to all three branches and updated consul's vendor directory for this

@preetapan preetapan mentioned this issue Aug 4, 2017
Closed
@preetapan preetapan mentioned this issue Aug 17, 2017
Open
@odegroot odegroot mentioned this issue Mar 13, 2018
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@preetapan preetapan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@preetapan @romfreiman