(TFECO-7531) fix(hcl): don't parse expressions containing an open curly brace as blocks #149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansgarm
force-pushed
the
fix-block-label-brace
branch
2 times, most recently
from
b112b70
to
e82224f
Compare
ansgarm
force-pushed
the
fix-block-label-brace
branch
from
e82224f
to
cc2b4d4
Compare
ansgarm
changed the title
jpogran
changed the title
jpogran
added a commit
to hashicorp/vscode-terraform
that referenced
this pull request
Sep 24, 2024
This commit updates the syntax version to 0.7.1, which fixes parsing expressions containing an open curly brace as blocks in hashicorp/syntax#149
jpogran
added a commit
to hashicorp/vscode-hcl
that referenced
this pull request
Sep 24, 2024
This commit updates the syntax version to 0.7.1, which fixes parsing expressions containing an open curly brace as blocks in hashicorp/syntax#149
jpogran
added a commit
to hashicorp/vscode-terraform
that referenced
this pull request
Sep 24, 2024
This commit updates the syntax version to 0.7.1, which fixes parsing expressions containing an open curly brace as blocks in hashicorp/syntax#149
jpogran
added a commit
to hashicorp/vscode-hcl
that referenced
this pull request
Sep 24, 2024
This commit updates the syntax version to 0.7.1, which fixes parsing expressions containing an open curly brace as blocks in hashicorp/syntax#149
jpogran
added a commit
to hashicorp/vscode-terraform
that referenced
this pull request
Sep 24, 2024
This commit updates the syntax version to 0.7.1, which fixes parsing expressions containing an open curly brace as blocks in hashicorp/syntax#149
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following problem in Terraform Test files (which use the HCL syntax instead of the more specialized Terraform one):
The grammar treats the opening brace that is part of the template string as a block and therefore breaks the following lines (mostly treated as a string).
This PR restricts parsing blocks as it only allows block labels to contain any character if that label is enclosed by double quotes. If it isn't only
\w-_are valid characters.