Bad highlighting when resource dot number notation is used in template string

[orgads]

Server Version

0.27.0

Terraform Version

Terraform v1.1.9
on windows_amd64

Client Version

VS Code

Terraform Configuration Files

locals {
  a = ["foo"]
}
output "foo" {
  value = {
    foo = "${local.a.0}a"
    bar = "This is not highlighted as a string"
  }
}

Log Output

https://gist.github.com/orgads/9e2edc3d4ab85de5beaeba113077ae63

Expected Behavior

a after the closing brace should be highlighted as a string, and bar should be highlighted as a symbol

Actual Behavior

Steps to Reproduce

Open VS Code and paste the code above.

Notice that changing local.a.0 to local.a[0] solves the issue.

[radeksimko]

Hi @orgads
Thank you for the report.

Since this part of highlighting is provided by the TextMate grammars and not by the language server I moved your issue over to the extension repo.

There is a chance this may be the same problem as described in hashicorp/vscode-terraform#1040 but I haven't had the time to confirm, so leaving this open until someone has time to confirm.

[radeksimko]

Turns out this is a separate issue - we just patched hashicorp/vscode-terraform#1040 upstream and I can still reproduce this:

[radeksimko]

While we work on fixing this, I'd also like to point out that more idiomatic way to write the same expression with the same meaning is with square brackets:

locals {
  a = ["foo"]
}
output "foo" {
  value = {
    foo = "${local.a[0]}a"
    bar = "This is not highlighted as a string"
  }
}

See also https://www.terraform.io/language/expressions/references#references-to-resource-attributes

[radeksimko]

PR with a fix is now pending review in #44