Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider highlighting grammar for function signatures #67

Open
2 tasks
radeksimko opened this issue Mar 23, 2023 · 0 comments
Open
2 tasks

Consider highlighting grammar for function signatures #67

radeksimko opened this issue Mar 23, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@radeksimko
Copy link
Member

Context

As part of hashicorp/terraform-ls#37 we discovered that there's need for rendering function signatures in a markdown hover popup. Because signatures aren't technically valid HCL, the existing grammar(s) do not highlight it particularly well. Specifically, the grammar cannot distinguish between type declaration and parameter name.

Screenshot 2023-03-23 at 09 17 01

Screenshot 2023-03-23 at 09 18 16

Proposal

  • Explore the option of a separate small grammar to highlight just function signatures
  • Discuss and agree on a stable/predictable way of rendering the signatures - e.g. how to present types (set(string) vs set of string; any single type vs dynamic etc.)
@radeksimko radeksimko added the enhancement New feature or request label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant