-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Acm certificate validation not handled properly #1393
Comments
I'm sure there's an example somewhere for this, but the closet I could find was #42 (comment) |
I don't think that will work since as suggested by the comment, |
update: found out about
update: Fixed it, this solution works. ( atleast I hope ) const validationRecord = new Route53.Route53Record(this, props.domainName + '_certificate_record', {
zoneId: hostedZone.zoneId,
allowOverwrite: true,
name: '${each.value.name}',
records: ['${each.value.record}'],
ttl: 60,
type: '${each.value.type}',
});
validationRecord.addOverride('for_each',
`\${{
for dvo in aws_acm_certificate.${certificateResource.friendlyUniqueId}.domain_validation_options : dvo.domain_name => {
name = dvo.resource_record_name
record = dvo.resource_record_value
type = dvo.resource_record_type
}
}}`,
);
let certificateDependable = new ACM.AcmCertificateValidation(this, props.domainName + '_certificate_validation', {
certificateArn: certificateResource.arn,
});
certificateDependable.addOverride('validation_record_fqdns', `\${[for record in aws_route53_record.${validationRecord.friendlyUniqueId} : record.fqdn]}`); |
I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
terraform-cdk/examples/typescript/aws-cloudfront-proxy/main.ts
Line 84 in 158d857
I referenced the code above, and produce something like the following.
Raises the following error
Futhermore I would like add a few alternative names as discussed here and would like to know the syntax for the same.
The text was updated successfully, but these errors were encountered: