Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve convertProject.test.ts by using locally build CDKTF version #2149

Closed
ansgarm opened this issue Sep 29, 2022 · 2 comments
Closed

Improve convertProject.test.ts by using locally build CDKTF version #2149

ansgarm opened this issue Sep 29, 2022 · 2 comments
Labels
dev-process Improvements to how CDK for Terraform is developed and built priority/important-longterm Medium priority, to be worked on within the following 1-2 business quarters. size/medium estimated < 1 week tech-debt testing

Comments

@ansgarm
Copy link
Member

ansgarm commented Sep 29, 2022

Stop using cdktf version published to NPM.

Shouldn't this also point to the dist directory (or similar) or does it not matter as the code is not synthesized?

Originally posted by @ansgarm in #2087 (comment)
@DanielMSchmidt DanielMSchmidt added testing priority/important-longterm Medium priority, to be worked on within the following 1-2 business quarters. dev-process Improvements to how CDK for Terraform is developed and built size/medium estimated < 1 week tech-debt labels Oct 11, 2022
@xiehan
Copy link
Member

xiehan commented Jun 2, 2023

This was done in ae86a51

@xiehan xiehan closed this as completed Jun 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 3, 2023

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
dev-process Improvements to how CDK for Terraform is developed and built priority/important-longterm Medium priority, to be worked on within the following 1-2 business quarters. size/medium estimated < 1 week tech-debt testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xiehan @ansgarm @DanielMSchmidt