-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Terraform 0.13 Compatibility #285
Conversation
We were planning to do this anyway. It became necessary now, since Terraform 0.13 added at least one new field to the schema (`description_kind`). This caused our snapshot tests to fail when running with different terraform versions
d6801ca
to
58537a2
Compare
I updated the jsii-terraform image with 0.12 and 0.13 binaries. We won't use tfenv for switching between Terraform versions as it requires us to install it by cloning the GitHub repo. We chose a simpler approach by installing the Terraform binaries from HashiCorp releases. |
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This adds Terraform 0.13 compatibility - Fixes #118
Noteworthy Changes:
0.12
and0.13
Terraform binaries inhashicorp/jsii-terraform
docker image.0.12
/0.13
cdktf.json
provider specifications can stay as they are todaydocker
), the provider specification has to be changed to a more specific nameExample
AWS Provider
This will work with Terraform
0.12
and0.13
, since HashiCorp maintained providers will be automatically handled by Terraform0.13
as well.Docker Provider
This will work with Terraform
0.12
and0.13
, since thesource
is ignore in0.12
This will only work in
0.12
Dependencies
This still needs #36 /cc @anubhavmishra