Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Streamline Usage of Prebuilt Providers #331

Merged
merged 12 commits into from
Aug 24, 2020
Merged

Streamline Usage of Prebuilt Providers #331

merged 12 commits into from
Aug 24, 2020

Conversation

skorfmann
Copy link
Contributor

@skorfmann skorfmann commented Aug 20, 2020

This streamlines the experience of using prebuilt Terraform providers:

In cdktf.json: When no terraformProviders and terraformModules are set, the check for the presence of codeMakerOutput is omitted. This allows running the check, even when using a prebuilt provider alongside custom generated providers or modules.

In addition, this pull request, introduces a minimal template (see #308). This is a good starter when using prebuilt providers.

Last but not least, it adds a bit of documentation.

Fixes #98
Fixes #284
Fixes #275
Fixes #308
Fixes #320

Copy link
Collaborator

@jsteinich jsteinich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking forward to using pre-built providers

docs/working-with-cdk-for-terraform/cdktf-json.md Outdated Show resolved Hide resolved
Comment on lines 7 to 13
- [AWS Provider](https://cdk.tf/provider/aws)
- [Google Provider](https://cdk.tf/provider/google)
- [Azure Provider](https://cdk.tf/provider/azurerm)
- [Kubernetes Provider](https://cdk.tf/provider/kubernetes)
- [Docker Provider](https://cdk.tf/provider/docker)
- [Github Provider](https://cdk.tf/provider/github)
- [Null Provider](https://cdk.tf/provider/null)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I"m curious how this list was chosen. I was expecting all hashicorp official providers.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly popularity, Github because I want to build an example case for Level 2 constructs and Null because it's a building block which useful for things like ecr asset

The current state is an advanced proof of concept. Mid / long term I think there would be more providers if not all at some point. For now, the goal is collecting feedback and building some examples to see if the UX is going in the right direction.

Things like:

  • versioning (version constraints for peer dependencies, how does it work in Python, ...)
  • major version changes (e.g. AWS 2.0 -> 3.0)
  • improve the auto publish pipeline
  • building upon these providers
  • adding tests to the provider publish pipeline

packages/cdktf-cli/lib/config.ts Outdated Show resolved Hide resolved
skorfmann and others added 2 commits August 21, 2020 22:47
…s.md

Co-authored-by: Anubhav Mishra <anubhavmishra@users.noreply.github.com>
…s.md

Co-authored-by: Anubhav Mishra <anubhavmishra@users.noreply.github.com>
@skorfmann skorfmann merged commit 4c4dd9c into master Aug 24, 2020
@skorfmann skorfmann deleted the prebuilt-providers branch August 24, 2020 20:13
@skorfmann skorfmann mentioned this pull request Aug 31, 2020
@github-actions
Copy link
Contributor

I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants