Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cdktf synth fails on windows when directory has whitespace in the name #502

Open
mikeparker opened this issue Jan 16, 2021 · 3 comments
Open
Labels
bug/has-workaround A bug with a workaround (may not be elegant) bug Something isn't working cdktf-cli help wanted Community contributions welcome as the core team is unlikely to work on this soon priority/backlog Low priority (though possibly still important). Unlikely to be worked on within the next 6 months. upstream/jsii Pending upstream work on JSII waiting-for-3rd-party-fix windows

Comments

@mikeparker
Copy link

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

cdktf & Language Versions

0.1.0 (2 days old)

Affected Resource(s)

Debug Output

https://gist.github.com/mikeparker/be19bd259f059c24cc2c6616d41d06fb
Specifically Error: Cannot find module 'C:\Users\Mike', note the truncated directory name due to whitespace

Expected Behavior

It completes successfully

Actual Behavior

It errored

Steps to Reproduce

Run cdktf synth on windows where node modules are in a directory with whitespace in directory name (e.g. inside windows user directory)

@mikeparker mikeparker added the bug Something isn't working label Jan 16, 2021
@jsteinich
Copy link
Collaborator

This seems likely to be caused by aws/jsii#1296

@skorfmann
Copy link
Contributor

Would the suggested workaround apply here as well? aws/jsii#1296 (comment)

PS C:\> $env:TMP = "C:\tmp"

@mikeparker
Copy link
Author

Yes, the workaround works :)

@danieldreier danieldreier added this to the 0.9 (tentative) milestone Sep 29, 2021
@DanielMSchmidt DanielMSchmidt added the needs-priority Issue has not yet been prioritized; this will prompt team review label Jan 25, 2022
@schersh schersh removed this from the 0.10 (tentative) milestone Jan 27, 2022
@DanielMSchmidt DanielMSchmidt added priority/important-soon High priority, to be worked on as part of our current release or the following one. and removed needs-priority Issue has not yet been prioritized; this will prompt team review labels Feb 17, 2022
@xiehan xiehan added the bug/has-workaround A bug with a workaround (may not be elegant) label Nov 22, 2022
@ansgarm ansgarm added the upstream/jsii Pending upstream work on JSII label Jan 10, 2023
@xiehan xiehan added help wanted Community contributions welcome as the core team is unlikely to work on this soon priority/backlog Low priority (though possibly still important). Unlikely to be worked on within the next 6 months. and removed priority/important-soon High priority, to be worked on as part of our current release or the following one. labels Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/has-workaround A bug with a workaround (may not be elegant) bug Something isn't working cdktf-cli help wanted Community contributions welcome as the core team is unlikely to work on this soon priority/backlog Low priority (though possibly still important). Unlikely to be worked on within the next 6 months. upstream/jsii Pending upstream work on JSII waiting-for-3rd-party-fix windows
Projects
None yet
Development

No branches or pull requests

8 participants