dependency is incorrectly generated for the terraform-module

[andrey-dubnik]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

cdktf & Language Versions

cdkf 0.1.0
Java

Affected Resource(s)

terraform-module

Expected Behavior

depends_on not dependsOn in the synth JSON

Steps to Reproduce

Create any module with depends on

TerraformHclModule.Builder.create(this, "module")
            .dependsOn(List.of(rg))

References

terraform-cdk/packages/cdktf/lib/terraform-module.ts

Line 75 in 1615302

dependsOn: this.dependsOn,

Should probably go via similar keysToSnakeCase transformation to

terraform-cdk/packages/cdktf/lib/terraform-resource.ts

Line 108 in 1615302

keysToSnakeCase(this.terraformMetaArguments),

[skorfmann]

@andrey-dubnik Thanks for raising this issue. Yes, this should be snake-cased. I'm wondering if just changing the dependsOn key would be sufficient.

Out of curiosity, what's your reason to use TerraformModule rather than imports?

[andrey-dubnik]

Changing the property may do it as well, although this would probably cause the lack of clarity which approach to take by addressing the same problem differently within the code base.

It seem imports can only handle modules from the public hashicorp registry where we use a private one hence needed to use a different approach with the TerraformModule.

[skorfmann]

It seem imports can only handle modules from the public hashicorp registry where we use a private one hence needed to use a different approach with the TerraformModule.

Yes, true. That's a current limitation which we'll be addressing in the future. Thanks for your feedback.

Changing the property may do it as well, although this would probably cause the lack of clarity which approach to take by addressing the same problem differently within the code base.

Absolutely. keysToSnakeCase turned out to be too greedy in some cases in the past. I'm not sure if terraformMetadata could potentially include user supplied objects which would cause the same issues again. So, that's something to double check where keysToSnakeCase is used. In this particular case, it's deviating from the other implementations already, due to the custom handling around providers.

[github-actions]

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.