Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable null for mapped attributes #813

Closed
skorfmann opened this issue Jun 30, 2021 · 1 comment · Fixed by #821
Closed

Enable null for mapped attributes #813

skorfmann opened this issue Jun 30, 2021 · 1 comment · Fixed by #821
Labels
bug Something isn't working priority/important-soon High priority, to be worked on as part of our current release or the following one. providers schema
Milestone

Comments

@skorfmann
Copy link
Contributor

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

cdktf & Language Versions

Probably all

Affected Resource(s)

AWS Route Table

Important Factoids

As written by @wuntusk in cdktf/cdktf-provider-aws#394

Currently RouteTable is unuseable

Currently you can't make a RouteTable since all routes require both a carrierGatewayId and a destinationPrefixListId. For some reason these 2 values never got an undefined check added so they never pass null but instead make a call to cdktf.stringToTerraform. I'm guessing this has never been caught as everyone is using the vpc module shown in the demos. If you try to roll your own pure Typescript VPC you'll run into this pretty quickly.

References

Potentially related to

@skorfmann skorfmann added bug Something isn't working new Un-triaged issue providers schema and removed new Un-triaged issue labels Jun 30, 2021
@danieldreier danieldreier added the priority/important-soon High priority, to be worked on as part of our current release or the following one. label Jul 2, 2021
@danieldreier danieldreier added this to the 0.6 milestone Jul 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2022

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working priority/important-soon High priority, to be worked on as part of our current release or the following one. providers schema
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants