Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import from Terraform doesn't reference module outputs correctly #859

Closed
jsteinich opened this issue Jul 29, 2021 · 2 comments · Fixed by #1120
Closed

Import from Terraform doesn't reference module outputs correctly #859

jsteinich opened this issue Jul 29, 2021 · 2 comments · Fixed by #1120
Labels
bug Something isn't working confirmed independently reproduced by an engineer on the team feature/convert priority/important-soon High priority, to be worked on as part of our current release or the following one.

Comments

@jsteinich
Copy link
Collaborator

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

cdktf & Language Versions

Latest build from main

Affected Resource(s)

Any module output

Expected Behavior

module outputs accessed via appropriate get method on TerraformHclModule

Actual Behavior

Module outputs are accessed as if they went through the code generation process, i.e. .Output

Steps to Reproduce

  1. Create terraform file referencing a module output when module is not from the registry
  2. Run cdtkf init from terraform
  3. Run cdktf synth
@jsteinich jsteinich added bug Something isn't working new Un-triaged issue labels Jul 29, 2021
@DanielMSchmidt DanielMSchmidt added feature/convert confirmed independently reproduced by an engineer on the team priority/important-soon High priority, to be worked on as part of our current release or the following one. and removed new Un-triaged issue labels Jul 29, 2021
@DanielMSchmidt
Copy link
Contributor

The problem would need to be solved in referenceToAst, it already detects modules, it just does the same for local and remote modules. This means we need to find out there if a module is remote or local, probably we can add this in the scope to decouple detection from action.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2022

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working confirmed independently reproduced by an engineer on the team feature/convert priority/important-soon High priority, to be worked on as part of our current release or the following one.
Projects
None yet
2 participants