Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert/import from TF: Use override logical id on construct id collision #890

Closed
jsteinich opened this issue Aug 3, 2021 · 2 comments · Fixed by #1045
Closed

Convert/import from TF: Use override logical id on construct id collision #890

jsteinich opened this issue Aug 3, 2021 · 2 comments · Fixed by #1045
Labels
enhancement New feature or request feature/convert needs-research priority/awaiting-more-evidence Lowest priority. Unlikely to be worked on unless/until it gets a lot more upvotes.

Comments

@jsteinich
Copy link
Collaborator

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

#845 handled construct id collisions by appending a number. We should override the logical id to be the original resource id when that happens so existing state could be used without having to rename.

References

#845
#329
@jsteinich jsteinich added enhancement New feature or request new Un-triaged issue feature/convert labels Aug 3, 2021
@DanielMSchmidt DanielMSchmidt added needs-priority Issue has not yet been prioritized; this will prompt team review and removed new Un-triaged issue labels Aug 3, 2021
@DanielMSchmidt
Copy link
Contributor

The collision detection is here and the overrides get added here.

@danieldreier danieldreier added needs-research priority/awaiting-more-evidence Lowest priority. Unlikely to be worked on unless/until it gets a lot more upvotes. and removed needs-priority Issue has not yet been prioritized; this will prompt team review labels Sep 2, 2021
@jsteinich jsteinich mentioned this issue Sep 17, 2021
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2022

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request feature/convert needs-research priority/awaiting-more-evidence Lowest priority. Unlikely to be worked on unless/until it gets a lot more upvotes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(hcl2cdk): Add logical id override when construct id's aren't unique jsteinich/terraform-cdk
3 participants
@DanielMSchmidt @jsteinich @danieldreier