Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Python templates to use RemoteBackend construct #644

Closed
ansgarm opened this issue Apr 19, 2021 · 2 comments
Closed

Update Python templates to use RemoteBackend construct #644

ansgarm opened this issue Apr 19, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers language/python
Milestone

Comments

@ansgarm
Copy link
Member

ansgarm commented Apr 19, 2021

Currently both Python templates use an override to specify a remote backend for Terraform state:

stack.add_override('terraform.backend', {
  'remote': {
    'hostname': 'app.terraform.io',
    'organization': '${organizationName}',
    'workspaces': {
      'name': '${workspaceName}'
    }
  }
})`);

Whereas the other templates (e.g. typescript) already use a dedicated construct for this:

new RemoteBackend(stack, {
  hostname: 'app.terraform.io',
  organization: '${organizationName}',
  workspaces: {
    name: '${workspaceName}'
  }
});`);

We should update the Python templates to use the construct instead of an override.

@ansgarm ansgarm added enhancement New feature or request good first issue Good for newcomers language/python v0.2 labels Apr 19, 2021
@danieldreier danieldreier added this to the v0.4 milestone Apr 19, 2021
@danieldreier danieldreier assigned ansgarm and unassigned ansgarm Apr 20, 2021
bradseiler added a commit to bradseiler/terraform-cdk that referenced this issue Apr 30, 2021
danieldreier added a commit that referenced this issue May 13, 2021
chore(#644): Upgrade python templates to use RemoteBackend class
@ansgarm
Copy link
Member Author

ansgarm commented May 19, 2021

Closed via #669

@github-actions
Copy link
Contributor

github-actions bot commented Dec 4, 2022

I'm going to lock this issue because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request good first issue Good for newcomers language/python
Projects
None yet
Development

No branches or pull requests

2 participants