Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use runtime.BuildInfo for version #22

Closed
kmoe opened this issue Jul 10, 2020 · 1 comment
Closed

use runtime.BuildInfo for version #22

kmoe opened this issue Jul 10, 2020 · 1 comment
Assignees
@kmoe
Milestone
v1.0.0

Comments

@kmoe
Copy link
Member

kmoe commented Jul 10, 2020

Instead of a constant in tfinstall/version.go, we could use https://golang.org/pkg/runtime/debug/#BuildInfo.
@kmoe kmoe mentioned this issue Jul 10, 2020
Merged
@kmoe kmoe self-assigned this Jul 13, 2020
@kmoe
Copy link
Member Author

kmoe commented Jul 13, 2020

Needs to be mocked during tests due to golang/go#33976

@paultyng paultyng mentioned this issue Aug 7, 2020
Closed
@paultyng paultyng added this to the v1.0.0 milestone Nov 18, 2020
@kmoe kmoe mentioned this issue Jul 11, 2022
Closed
@kmoe kmoe closed this as completed Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kmoe kmoe

Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
2 participants
@paultyng @kmoe