Make LS compatible with Terraform v0.13

[radeksimko]

Current Version

v0.2.1

Use-cases

Terraform 0.13 will be released soon and users should be able to use LS with that version.

Proposal

One known issue is different location of the lock file, which is currently set here

terraform-ls/internal/terraform/schema/watcher.go

Lines 46 to 52 in b0f90d0

	func lockFilePath(dir string) string {
	return filepath.Join(dir,
	".terraform",
	"plugins",
	runtime.GOOS+"_"+runtime.GOARCH,
	"lock.json")
	}

the new location is apparently .terraform/plugins/selections.json - which seems platform-agnostic, so that's positive, but we may not be able to just automatically look for that new path based on Terraform version, because v0.13 doesn't seem to be moving the old lock file to the new location.

[paultyng]

Maybe you could just watch both versions for now?

[paultyng]

Since the beta is out now, probably need to bump the priority.

[apparentlymart]

Related to this, I notice that the language server is using hashicorp/go-version's Constraints.Check method to verify that it's working with Terraform 0.12 or later:

terraform-ls/internal/terraform/lang/parser.go

Line 49 in 4d7a0e8

if !c.Check(tfVersion) {

Unfortunately go-version doesn't consider prerelease versions (like 0.13.0-beta1) as matching version a constraint unless they are specified exactly in the version constraint. (That is, the constraint would have to exactly include 0.13.0-beta1 in order to match this version.)

In order to avoid reporting beta versions as unsupported, perhaps instead it could be written as a comparison of Version values, like this:

minimumVersion := version.Must(version.NewVersion("0.12.0")
tfVersion.GreaterThanOrEqual(minimumVersion)

IIRC the prerelease special case applies to Constraints.Check specifically, and doesn't affect the precedence results indicated by the Version methods.

[ghost]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.