Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make formatting a built-in feature (avoid depending on Terraform CLI) #1303

Open
radeksimko opened this issue Jun 6, 2023 · 3 comments
Open
Labels
enhancement New feature or request

Comments

@radeksimko
Copy link
Member

Context

Throughout past years we received numerous reports about "not working formatting". With a little bit of eye twitching, they can be roughly divided in two buckets:

  • VS Code related problems to either settings or extension conflicts
  • Terraform CLI related problems
    • missing or misconfigured entry in $PATH
    • Terraform not installed at all
    • Terraform "hidden" behind wrappers such as tfenv and other version managers, which return unexpected output from terraform version when the given TF version isn't already installed

This issue focuses on the second bucket which is more within our control.

Past related issues:

This also happens to be a pre-requisite for #613

Proposal

Consider re-implementing terraform fmt as part of the language server, to reduce the "number of moving parts" and make formatting work out of the box for users.

@Goobles

This comment was marked as off-topic.

@dbanck

This comment was marked as off-topic.

@Goobles

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants