Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize the work we do on didChange #1339

Open
dbanck opened this issue Jul 31, 2023 · 1 comment · Fixed by #1404
Open

Optimize the work we do on didChange #1339

dbanck opened this issue Jul 31, 2023 · 1 comment · Fixed by #1404
Assignees
@jpogran
Labels
enhancement New feature or request needs-research performance Gotta go fast

Comments

@dbanck
Copy link
Member

dbanck commented Jul 31, 2023 •
edited
Loading

Language Server Version

v0.31.3

Problem Statement

We run a lot of jobs and background updates on every didChange call. Adding early validation to this could further slow performance for large files/workspaces.

Proposal

  • Look into reducing the amount we do on each keystroke
    • maybe improve change batching
    • maybe debounce running changes until a user stops typing (~250ms?)

Related LSP methods

  • textDocument/didChange

Part of hashicorp/vscode-terraform#720
@dbanck dbanck added enhancement New feature or request performance Gotta go fast labels Jul 31, 2023
@dbanck dbanck mentioned this issue Jul 31, 2023
Open
@radeksimko radeksimko mentioned this issue Jul 31, 2023
Closed
1 task
This was referenced Aug 15, 2023
Open
Open
@dbanck dbanck linked a pull request Sep 18, 2023 that will close this issue
Update ParseModuleConfiguration to only parse changed file (*.tf) #1404
Merged
@jpogran
Copy link
Contributor

jpogran commented Sep 22, 2023

Reopening because I think that while #1404 address a big portion, it doesn't address all of this ticket.

@jpogran jpogran reopened this Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jpogran jpogran

Labels
enhancement New feature or request needs-research performance Gotta go fast
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update ParseModuleConfiguration to only parse changed file (*.tf) hashicorp/terraform-ls
2 participants
@dbanck @jpogran