Split monolithic state into multiple entities

[dbanck]

• Part of Improve language extensibility #1614

---

Split the current Module struct into three smaller structs: Module, Vars, Common (names TBD)

terraform-ls/internal/state/module.go

Lines 93 to 138 in 62b906e

	type Module struct {
	Path string
	ModManifest *datadir.ModuleManifest
	ModManifestErr error
	ModManifestState op.OpState
	TerraformVersion *version.Version
	TerraformVersionErr error
	TerraformVersionState op.OpState
	InstalledProviders InstalledProviders
	InstalledProvidersErr error
	InstalledProvidersState op.OpState
	ProviderSchemaErr error
	ProviderSchemaState op.OpState
	PreloadEmbeddedSchemaState op.OpState
	RefTargets reference.Targets
	RefTargetsErr error
	RefTargetsState op.OpState
	RefOrigins reference.Origins
	RefOriginsErr error
	RefOriginsState op.OpState
	VarsRefOrigins reference.Origins
	VarsRefOriginsErr error
	VarsRefOriginsState op.OpState
	ParsedModuleFiles ast.ModFiles
	ParsedVarsFiles ast.VarsFiles
	ModuleParsingErr error
	VarsParsingErr error
	Meta ModuleMetadata
	MetaErr error
	MetaState op.OpState
	ModuleDiagnostics ast.SourceModDiags
	ModuleDiagnosticsState ast.DiagnosticSourceState
	VarsDiagnostics ast.SourceVarsDiags
	VarsDiagnosticsState ast.DiagnosticSourceState
	}

• Modules
  • Directory Path
  • Collected Reference Targets
  • Collected Reference Origins
  • Parsed Module Files
  • Diagnostics for Module Files
  • Metadata
• Vars
  • Directory Path
  • Collected Variable Definition Reference Origins
  • Parsed Variable Definition Files
  • Diagnostics for Variable Definition Files
• Common
  • Directory Path
  • Module Manifest (parsed .terraform/modules/modules.json)
  • Installed Terraform Version
  • Installed Providers

In the future this will allow us to create more state structs for more languages, like test or stacks.

[dbanck]

Closed via #1667

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.