Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Go version to 1.23.2 #1849

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Bump Go version to 1.23.2 #1849

merged 1 commit into from
Oct 16, 2024

Conversation

dbanck
Copy link
Member

@dbanck dbanck commented Oct 16, 2024

github.com/vektra/mockery/v2 requires Go 1.23 since the version bump in 6deb5b4

I see no downside to bumping the Go version for the LS and removing the toolchain entry

@dbanck dbanck requested a review from a team as a code owner October 16, 2024 10:12
@dbanck dbanck force-pushed the c-bump-go-version branch from 7083ccc to 8ebf32b Compare October 16, 2024 10:13
Copy link
Member

@ansgarm ansgarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dbanck dbanck merged commit d398716 into main Oct 16, 2024
21 of 22 checks passed
@dbanck dbanck deleted the c-bump-go-version branch October 16, 2024 14:01
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants