Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix request cancellation #314

Closed
radeksimko opened this issue Nov 20, 2020 · 1 comment · Fixed by #514
Closed

Fix request cancellation #314

radeksimko opened this issue Nov 20, 2020 · 1 comment · Fixed by #514
Labels
bug Something isn't working

Comments

@radeksimko
Copy link
Member

radeksimko commented Nov 20, 2020

Request cancellation via LSP's $/cancelRequest don't work since #120 which disabled concurrency.

Cancellation requests therefore now end up queued behind the request which may need to be cancelled.

0aa7c0f contains a failing test to reproduce this.

Server Version

0.10.0
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant