-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate tflint with focus on a generalized linter/validator interface #334
Comments
@dbanck I'm currently interested in working on this, here is the PoC: As I understand it, #856 has already been resolved, so there are no related fixes in the PoC. If you are able to move this forward I would be happy to submit a PR, which can be split into separate PRs for each step outlined here, or combined. Please let me know if we need to discuss the overall design before we move forward. Also, since the architecture will change significantly in #1667, it would be fine to implement it after that. |
This is part of hashicorp/vscode-terraform#635
Use-cases
(Follow up on #27)
The user can run
terraform validate
since 0.11 as a command (if dedicated clients such as VS Code extension choose to integrate) and can also run this ondidSave
automatically.The integration of linters requires similar work and could be implemented as a command, which can be executed on
didSave
as well.Proposal
tflint
tflint
as an executable command, which calls thetflint
binary, similar tovalidate
terraform-ls/internal/langserver/handlers/command/validate.go
Lines 57 to 65 in e7abb2f
tflint --json
and how to store it in the diagnostics memdb table introduced in Store diagnostics in memdb table #856tflint
to thedidSave
handler, similar tovalidate
terraform-ls/internal/langserver/handlers/did_save.go
Lines 18 to 29 in e7abb2f
The text was updated successfully, but these errors were encountered: