Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

filesystem: Support incremental updates #34

Closed
radeksimko opened this issue Mar 22, 2020 · 1 comment · Fixed by #103
Closed

filesystem: Support incremental updates #34

radeksimko opened this issue Mar 22, 2020 · 1 comment · Fixed by #103
Labels
enhancement New feature or request text-synchronization https://microsoft.github.io/language-server-protocol/specifications/specification-current/#textDocum

Comments

@radeksimko
Copy link
Member

The current implementation updates file content in full (from the first to last byte), which may cost more resources than necessary. This is usually not noticeable if users open smaller files, but may become an issue for users with bigger files.

Keeping files small helps maintainability and is a good practice in general (and hence expected in most cases), but we may not want to hurt the UX for the edge cases with big files too much either.

Incremental updates are part of the LSP and both server and client have to opt-in via relevant capabilities:
https://microsoft.github.io/language-server-protocol/specifications/specification-current/#textDocument_synchronization_sc

@radeksimko radeksimko added the enhancement New feature or request label Mar 22, 2020
@radeksimko radeksimko added the text-synchronization https://microsoft.github.io/language-server-protocol/specifications/specification-current/#textDocum label May 12, 2020
@njuCZ njuCZ mentioned this issue May 18, 2020
@ghost
Copy link

ghost commented Jun 28, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Jun 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request text-synchronization https://microsoft.github.io/language-server-protocol/specifications/specification-current/#textDocum
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant