Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address flaky exit handler test #445

Closed
radeksimko opened this issue Mar 22, 2021 · 1 comment · Fixed by #1049
Closed

Address flaky exit handler test #445

radeksimko opened this issue Mar 22, 2021 · 1 comment · Fixed by #1049
Assignees
@dbanck
Labels
technical-debt

Comments

@radeksimko
Copy link
Member

The following test failed on 5abae0c

--- FAIL: TestExit (0.00s)
    exit_test.go:20: Expected service stop function to be called
FAIL

Probably because receiving/processing the request takes a moment and is done in a separate goroutine of upstream library.
@dbanck dbanck mentioned this issue Aug 25, 2022
Merged
@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dbanck dbanck

Labels
technical-debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: flaky exit handler test hashicorp/terraform-ls
2 participants
@dbanck @radeksimko