Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish release binaries to releases.hashicorp.com #49

Closed
paultyng opened this issue Apr 14, 2020 · 5 comments · Fixed by #102
Closed

Publish release binaries to releases.hashicorp.com #49

paultyng opened this issue Apr 14, 2020 · 5 comments · Fixed by #102
Assignees
Labels
ci Continuous integration/delivery related
Milestone

Comments

@paultyng
Copy link
Contributor

paultyng commented Apr 14, 2020

In addition to the GitHub release.

We should also build the JSON index as well to determine latest version.

@paultyng paultyng added the enhancement New feature or request label Apr 14, 2020
@radeksimko radeksimko added ci Continuous integration/delivery related and removed enhancement New feature or request labels Apr 14, 2020
@radeksimko
Copy link
Member

I'd expect hc-releases here to do most of the hard work (including the index building?), but I'm not that familiar with it, so I'll need to read through the implementation/docs.

We could plug it into the existing GitHub Action either as a next step after GoReleaser, or send a patch to GoReleaser to support global post hooks, similar to pre-hooks: https://goreleaser.com/customization/#Global%20Hooks
and then plug it in there.

@paultyng
Copy link
Contributor Author

I think probably easiest to just chain it afterwards in the GitHub action unless there is some context you'd want to reuse that goreleaser would provide?

@radeksimko
Copy link
Member

The benefit of reusing GoReleaser pipeline is that we could publish Homebrew/Scoop formula with our releases.hashicorp.com URLs, which make it much easier for us to track downloads in much more detailed way - including the ability to segment downloads via Homebrew or Scoop.

Technically we could do that even without any GoReleaser patches, but we'd be publishing Homebrew/Scoop updates before the binaries are actually uploaded and available, which is a bit awkward.

Download tracking via GitHub API is currently very minimal as it doesn't go beyond a single number representing total download count 😑 , so we wouldn't be able to identify Homebrew or Scoop downloads that way and tracking weekly or monthly downloads would also be more difficult.

@radeksimko
Copy link
Member

I created goreleaser/goreleaser#1460 to gather some preliminary feedback on a potential upstream patch that could support this integration.

@ghost
Copy link

ghost commented Jun 18, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the context necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Jun 18, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
ci Continuous integration/delivery related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants