Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide token modifiers for traversals (references) #836

Open
radeksimko opened this issue Mar 17, 2022 · 0 comments
Open

Provide token modifiers for traversals (references) #836

radeksimko opened this issue Mar 17, 2022 · 0 comments
Labels
enhancement New feature or request textDocument/semanticTokens Semantic syntax highlighting workspace/semanticTokens

Comments

@radeksimko
Copy link
Member

This is in follow-up to #833

Background

In the above PR we introduce custom semantic token types and modifiers, to enable themes to address configuration parts more accurately and using more familiar names.

Modifiers per traversal segment

There are some ideas shared by a theme creator who mentioned they'd want to highlight each segment separately, i.e. for data.aws_availability_zones.available.names there would be 4 different modifiers.

And there are some limitations discovered in hashicorp/vscode-terraform#574 (comment). That's not to say these are unsolvable but may present some challenges and additional overhead in implementation.

Modifiers for whole traversal

We could also provide modifier for the whole traversal, e.g. reuse terraform-data for data.aws_availability_zones.available.names and generally any references to data blocks.

Proposal

TODO

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request textDocument/semanticTokens Semantic syntax highlighting workspace/semanticTokens
Projects
None yet
Development

No branches or pull requests

1 participant